Make error overlay translucent #1097
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbogdan
changed the title
Merged
|
@lbogdan we can merge this, but as an FYI the overlay and such is going to get a complete makeover for 3.0.0. |
|
@shellscape Nice, I hope it will be translucent! It would be nice if you could merge this, so that I don't have to "patch" it in |
lbogdan
force-pushed
the
feature/translucent-overlay
branch
from
3849fec to
631c24e
Compare
Codecov Report
@@ Coverage Diff @@
## master #1097 +/- ##
=======================================
Coverage 71.92% 71.92%
=======================================
Files 5 5
Lines 463 463
Branches 148 148
=======================================
Hits 333 333
Misses 130 130Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Error overlay translucence.
Did you add or update the
examples/?Not needed.
Summary
Being used to
webpack-hot-middleware's error overlay, which has an alpha of 0.85, it is a bit misleading when getting a completely opaque overlay. This change makes the error overlay's background the same aswebpack-hot-middleware's.Does this PR introduce a breaking change?
No.