Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor client #1137

Merged
merged 23 commits into from
Oct 12, 2017
Merged

Refactor client #1137

merged 23 commits into from
Oct 12, 2017

Conversation

shellscape
Copy link
Contributor

What kind of change does this PR introduce?
This PR contains a refactor of the /client directory, intended for the version 3 milestone. It's intended to provide a cleaner experience, organization, and maintainability, and offer the ability to test modularly.

Did you add or update the examples/?
Yes

Summary
This is part of the larger refactor, cleanup, and update of the module for v3.

Does this PR introduce a breaking change?
Nope

Other information

@codecov
Copy link

codecov bot commented Oct 6, 2017

Codecov Report

Merging #1137 into beta will decrease coverage by 0.12%.
The diff coverage is 69.23%.

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #1137      +/-   ##
==========================================
- Coverage   76.74%   76.61%   -0.13%     
==========================================
  Files           5        5              
  Lines         473      479       +6     
  Branches      152      153       +1     
==========================================
+ Hits          363      367       +4     
- Misses        110      112       +2
Impacted Files Coverage Δ
lib/util/addDevServerEntrypoints.js 10.52% <0%> (ø) ⬆️
lib/Server.js 83.72% <75%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bc8f3c5...543321b. Read the comment docs.

@shellscape shellscape force-pushed the beta branch 3 times, most recently from d448a9a to bc8f3c5 Compare October 10, 2017 01:56
@shellscape shellscape merged commit 72d5a54 into beta Oct 12, 2017
@shellscape shellscape mentioned this pull request Oct 13, 2017
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant