-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor client #1137
Merged
Merged
Refactor client #1137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er into refactor-client
Codecov Report
@@ Coverage Diff @@
## beta #1137 +/- ##
==========================================
- Coverage 76.74% 76.61% -0.13%
==========================================
Files 5 5
Lines 473 479 +6
Branches 152 153 +1
==========================================
+ Hits 363 367 +4
- Misses 110 112 +2
Continue to review full report at Codecov.
|
shellscape
force-pushed
the
beta
branch
3 times, most recently
from
October 10, 2017 01:56
d448a9a
to
bc8f3c5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
This PR contains a refactor of the
/client
directory, intended for the version 3 milestone. It's intended to provide a cleaner experience, organization, and maintainability, and offer the ability to test modularly.Did you add or update the
examples/
?Yes
Summary
This is part of the larger refactor, cleanup, and update of the module for v3.
Does this PR introduce a breaking change?
Nope
Other information