Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'log' is not a function error #1253

Closed
wants to merge 1 commit into from
Closed

Conversation

bcinarli
Copy link

@bcinarli bcinarli commented Jan 3, 2018

What kind of change does this PR introduce?
Enhancement / Bugfix

Did you add or update the examples/?
N/A

Summary
When starting devServer with --progress option on, it fires an error as,

node_modules/webpack-dev-server/lib/cli/util.js:56
log();
^
TypeError: log is not a function

This is because, in argv.progress check, logs trying to called as log() instead of log.info()

Does this PR introduce a breaking change?
No

Other information
devServer version is: 3.0.0-alpha6
reported issue: #1244

/Users/cinarbil/Dev/webpack-demo/node_modules/webpack-dev-server/lib/cli/util.js:56
      log();
      ^

TypeError: log is not a function
    at ready (/Users/cinarbil/Dev/webpack-demo/node_modules/webpack-dev-server/lib/cli/util.js:56:7)
    at Server.devServer.listen (/Users/cinarbil/Dev/webpack-demo/node_modules/webpack-dev-server/lib/cli/start.js:61:7)
    at Server.returnValue.server.listen (/Users/cinarbil/Dev/webpack-demo/node_modules/webpack-dev-server/lib/DevServer.js:179:18)
    at Object.onceWrapper (events.js:254:19)
    at Server.emit (events.js:164:20)
    at Server.emit (/Users/cinarbil/Dev/webpack-demo/node_modules/spdy/lib/spdy/server.js:237:40)
    at emitListeningNT (net.js:1394:10)
    at _combinedTickCallback (internal/process/next_tick.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

When running with `--progress` options, it triggers an error as 'log is not a function'.
@jsf-clabot
Copy link

jsf-clabot commented Jan 3, 2018

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 3, 2018

Codecov Report

Merging #1253 into next will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             next    #1253   +/-   ##
=======================================
  Coverage   73.39%   73.39%           
=======================================
  Files           9        9           
  Lines         560      560           
  Branches      145      145           
=======================================
  Hits          411      411           
  Misses        149      149

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2463030...0d11dcc. Read the comment docs.

@bcinarli bcinarli changed the title Fix 'log' is not a function error #1244 Fix 'log' is not a function error Jan 3, 2018
@shellscape
Copy link
Contributor

Unfortunately @next is no longer being worked on. The team has decided on a change of direction. We do very much appreciate the contribution though!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants