Emit progress-update event on the listeningApp, allowing update progress to be obtained in the node API. #1666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ess to be obtained in the node API.
```
new webpackDevServer(webpack, config).listen(port, hostname, function (err) {
this.on('progress-update', ({ percent, msg }) => {
console.log(`${percent}% - ${msg}.`);
});
});
```
pfdgithub
requested review from
alexander-akait and
michael-ciniawsky
as code owners
|
|
alexander-akait
approved these changes
Feb 15, 2019
alexander-akait
requested changes
Feb 15, 2019
Codecov Report
@@ Coverage Diff @@
## master #1666 +/- ##
==========================================
- Coverage 84.39% 84.06% -0.33%
==========================================
Files 7 7
Lines 519 521 +2
Branches 159 160 +1
==========================================
Hits 438 438
- Misses 64 65 +1
- Partials 17 18 +1
Continue to review full report at Codecov.
|
|
Please accept CLA |
|
Friendly ping @pfdgithub |
hiroppy
added a commit
that referenced
this pull request
Apr 3, 2020
6 tasks
hiroppy
added a commit
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Motivation / Use-Case
Breaking Changes
Additional Info
Just like in the browser, we can now get the compilation progress of the current project in the node API.