Fixed issue when certificates are not imported on runtime #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shobhitsharma
requested review from
alexander-akait and
hiroppy
as code owners
|
|
2 tasks
Codecov Report
@@ Coverage Diff @@
## master #1686 +/- ##
========================================
- Coverage 79.59% 79.2% -0.4%
========================================
Files 7 7
Lines 544 553 +9
Branches 165 169 +4
========================================
+ Hits 433 438 +5
- Misses 84 88 +4
Partials 27 27
Continue to review full report at Codecov.
|
|
Hi can we merge this ASAP @evilebottnawi @hiroppy 🙏 |
hiroppy
approved these changes
Feb 24, 2019
Member
hiroppy
left a comment
hiroppy
left a comment
There was a problem hiding this comment.
Thank you for fixing this issue. LGTM
Sorry but I don't have webpack-dev-server's read-write right of npm so we wait for @evilebottnawi
alexander-akait
requested changes
Feb 25, 2019
Member
alexander-akait
left a comment
alexander-akait
left a comment
There was a problem hiding this comment.
Need tests, also please avoid fs.readFileSync and path.resolve, we already do this in Server
Member
|
WIP on this |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added back argument parser for certificates which resolves issue with custom domain.
Fixes #1675