-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
exclude /node_modules/ from _watch by default #1794
Conversation
lib/Server.js
Outdated
} | ||
// ignoring node_modules folder by default | ||
options.watchOptions.ignored = | ||
options.watchOptions.ignored || /node_modules/; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need use here [/node_modules/]
. also need add tests to avoid future regressions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for PR, you can find example of tests in test/ContentBase.js
Codecov Report
@@ Coverage Diff @@
## master #1794 +/- ##
==========================================
+ Coverage 89.14% 89.19% +0.05%
==========================================
Files 9 9
Lines 608 611 +3
Branches 185 186 +1
==========================================
+ Hits 542 545 +3
Misses 54 54
Partials 12 12
Continue to review full report at Codecov.
|
@evilebottnawi Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/cc @hiroppy
CI is green |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
@hiroppy You're Welcome 😄 |
Users using html-webpack-plguin are many and this change causes many impacts. /cc @evilebottnawi |
For Bugs and Features; did you add new tests?
I'm not sure how exactly to write a test for this except testing it manually.
Motivation / Use-Case
fixes #1781
Breaking Changes
No
Additional Info
I had a very strange behavior when I try to change the value of
this.watchOptions
when I dochokidar always reads the ignored option as undefined even if i try to edit the value of this.watchOptions just right before setting it's options.
it works only with me the way I did the change
So what's wrong about it? and if I can write a test for this how would I test it.