Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): upgrade node.js version from 11 to 12 #1816

Closed
wants to merge 1 commit into from

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Apr 23, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

just Node.js version update on CI

Breaking Changes

no

Additional Info

@alexander-akait
Copy link
Member

alexander-akait commented Apr 24, 2019

Looks we need wait release node@12 on appveyor

@hiroppy hiroppy force-pushed the feature/change-node-version-from-11-to-12 branch from 777e2fa to fb312cc Compare April 26, 2019 21:00
@codecov
Copy link

codecov bot commented Apr 26, 2019

Codecov Report

Merging #1816 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1816   +/-   ##
=======================================
  Coverage   87.66%   87.66%           
=======================================
  Files           9        9           
  Lines         608      608           
  Branches      185      185           
=======================================
  Hits          533      533           
  Misses         63       63           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5195bfa...fb312cc. Read the comment docs.

@hiroppy
Copy link
Member Author

hiroppy commented Apr 26, 2019

related appveyor/ci#2921

@alexander-akait
Copy link
Member

I think we need migrate on azure pipelines, i will do this in near future

@hiroppy hiroppy closed this May 8, 2019
@hiroppy hiroppy deleted the feature/change-node-version-from-11-to-12 branch May 8, 2019 16:16
@hiroppy
Copy link
Member Author

hiroppy commented May 8, 2019

We have already migrated to azure pipelines:)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants