Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Union sock options #2047

Merged
merged 3 commits into from
Sep 25, 2019
Merged

Union sock options #2047

merged 3 commits into from
Sep 25, 2019

Conversation

EslamHiko
Copy link
Member

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Used existing tests

Motivation / Use-Case

It's in the To Do list

Breaking Changes

Using sockHost, sockPath and sockPort options will be invalid. they must be used in the new clientSocketOptions option.

Additional Info

@codecov
Copy link

codecov bot commented Jun 17, 2019

Codecov Report

Merging #2047 into master will decrease coverage by 1.21%.
The diff coverage is 76.19%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2047      +/-   ##
==========================================
- Coverage    93.9%   92.69%   -1.22%     
==========================================
  Files          34       29       -5     
  Lines        1280     1163     -117     
  Branches      368      338      -30     
==========================================
- Hits         1202     1078     -124     
- Misses         71       81      +10     
+ Partials        7        4       -3
Impacted Files Coverage Δ
lib/Server.js 92.54% <100%> (-4.78%) ⬇️
lib/utils/addEntries.js 100% <100%> (ø) ⬆️
lib/utils/createConfig.js 90.35% <28.57%> (-6.11%) ⬇️
lib/utils/runBonjour.js 14.28% <0%> (-57.15%) ⬇️
lib/utils/colors.js 50% <0%> (-50%) ⬇️
client-src/clients/BaseClient.js 33.33% <0%> (-41.67%) ⬇️
lib/utils/routes.js 90.19% <0%> (-2.31%) ⬇️
lib/utils/status.js 90% <0%> (-1.31%) ⬇️
... and 13 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 25f1b57...a2a5102. Read the comment docs.

Copy link
Member

@hiroppy hiroppy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm -1 on this change. And this is breaking changes, so we cannot merge to the master branch.

@hiroppy
Copy link
Member

hiroppy commented Jun 17, 2019

@EslamHiko If you want to change something(e.g. add new feature, breaking changes, etc...), please submit an issue because we need to discuss before implementation. Thanks.

@alexander-akait
Copy link
Member

alexander-akait commented Jun 24, 2019

Yes, we should do this for next branch, also we still need discussion how handle CLI arguments for this, i.e. we need e2e tests for this

@EslamHiko
Copy link
Member Author

@evilebottnawi I'll change the base branch to next, and for CLI arguments I handled them in lib/utils/createConfig.js

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ hiroppy
✅ Loonride
✅ EslamHiko
❌ renovate[bot]

@EslamHiko EslamHiko changed the base branch from master to next September 25, 2019 16:25
@EslamHiko EslamHiko merged commit fe80fa4 into webpack:next Sep 25, 2019
@EslamHiko EslamHiko deleted the union-sock-options branch September 25, 2019 16:26
EslamHiko added a commit that referenced this pull request Sep 25, 2019
@EslamHiko
Copy link
Member Author

EslamHiko commented Sep 25, 2019

@hiroppy @evilebottnawi I'm Sorry, I accidentally merged this PR into next branch. I'll revert it and create another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants