feat(server): serverMode 'ws' option #2082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2082 +/- ##
==========================================
+ Coverage 94.46% 94.47% +<.01%
==========================================
Files 32 32
Lines 1210 1212 +2
Branches 334 335 +1
==========================================
+ Hits 1143 1145 +2
Misses 65 65
Partials 2 2
Continue to review full report at Codecov.
|
|
@Loonride plz rebase |
knagaitsev
force-pushed
the
ws-string-serverMode-option
branch
from
4c12f80
to
34f3219
Compare
|
I just added some tests to confirm through mocks that the server interacts with the socket server implementation correctly. I'm not sure if |
hiroppy
previously approved these changes
Jul 3, 2019
|
I think it is ok. |
knagaitsev
force-pushed
the
ws-string-serverMode-option
branch
from
fbb855a
to
68c07ba
Compare
|
Something wrong with prettier, need fix |
|
Not sure what the problem was exactly, but seems to be fixed |
hiroppy
approved these changes
Jul 5, 2019
anikethsaha
pushed a commit
to anikethsaha/webpack-dev-server
that referenced
this pull request
Jul 7, 2019
* feat(server): server mode ws string option * test(server): rearrange bad host test * test(server): added mock server implementation tests * test(server): remove bad host test temporarily * test(server): re added bad host test
knagaitsev
added a commit
to knagaitsev/webpack-dev-server
that referenced
this pull request
Jul 31, 2019
* feat(server): server mode ws string option * test(server): rearrange bad host test * test(server): added mock server implementation tests * test(server): remove bad host test temporarily * test(server): re added bad host test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Adds the option
serverMode: 'ws'. Please review and merge #2077 before this.I still want to work on
serverMode-option.test.jsfurther such that it tests to see thatServer.jsinteracts with a socket server implementation correctly. Currently, it only checks thatServer.jscalls the constructor of the server implementation. I will work on this later.Breaking Changes
None
Additional Info