Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update package-lock.json #2123

Merged
merged 1 commit into from
Jul 16, 2019
Merged

Conversation

hiroppy
Copy link
Member

@hiroppy hiroppy commented Jul 15, 2019

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

no

Motivation / Use-Case

run audit fix.


>= 4.17.12

├─┬ @commitlint/cli@8.0.0
│ ├─┬ @commitlint/lint@8.0.0
│ │ ├─┬ @commitlint/parse@8.0.0
│ │ │ ├─┬ conventional-commits-parser@2.1.7
│ │ │ │ └── lodash@4.17.14  deduped
│ │ │ └── lodash@4.17.14  deduped
│ │ ├─┬ @commitlint/rules@8.0.0
│ │ │ └─┬ @commitlint/ensure@8.0.0
│ │ │   └── lodash@4.17.11 
│ │ └── lodash@4.17.11 
│ ├─┬ @commitlint/load@8.0.0
│ │ ├─┬ @commitlint/resolve-extends@8.0.0
│ │ │ └── lodash@4.17.11 
│ │ └── lodash@4.17.11 
│ └── lodash@4.17.11 

These PRs have merged but they haven't published new version yet, so we cannot fix.(because they lock lodash's version)
conventional-changelog/commitlint@4cb979d
conventional-changelog/commitlint#724

Breaking Changes

no

Additional Info

@codecov
Copy link

codecov bot commented Jul 15, 2019

Codecov Report

Merging #2123 into master will decrease coverage by 2.06%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2123      +/-   ##
==========================================
- Coverage   94.65%   92.58%   -2.07%     
==========================================
  Files          32       32              
  Lines        1215     1267      +52     
  Branches      340      357      +17     
==========================================
+ Hits         1150     1173      +23     
- Misses         63       90      +27     
- Partials        2        4       +2
Impacted Files Coverage Δ
client-src/clients/SockJSClient.js 59.45% <0%> (-40.55%) ⬇️
client-src/clients/WebsocketClient.js 57.14% <0%> (-28.58%) ⬇️
client-src/clients/BaseClient.js 75% <0%> (+41.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d3da508...c5a892a. Read the comment docs.

@alexander-akait
Copy link
Member

commitlint still have problem 😕

@alexander-akait
Copy link
Member

alexander-akait commented Jul 15, 2019

Try to full remove package-lock and install again packages with new package-lock

@alexander-akait
Copy link
Member

/cc @hiroppy need update again, looks new version without vulnerables was released

@hiroppy
Copy link
Member Author

hiroppy commented Jul 15, 2019

wow, good timing. updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants