Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move webpack-cli as a dependency #2257

Conversation

vhiairrassary
Copy link

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Is there any test I can add to be confident with that change?

Motivation / Use-Case

#2256

webpack-cli is required at https://github.com/webpack/webpack-dev-server/blob/master/bin/webpack-dev-server.js#L65 but it is listed as a devDependencies and not as a dependencies which is not compatible with Yarn PnP.

Feel free to close this PR if it does not make sense.

Breaking Changes

I have not enough knowledge about webpack-dev-server's internal to answer this.

@jsf-clabot
Copy link

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

@vhiairrassary vhiairrassary mentioned this pull request Sep 20, 2019
1 task
@codecov
Copy link

codecov bot commented Sep 20, 2019

Codecov Report

Merging #2257 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #2257   +/-   ##
======================================
  Coverage    93.9%   93.9%           
======================================
  Files          34      34           
  Lines        1280    1280           
  Branches      368     368           
======================================
  Hits         1202    1202           
  Misses         71      71           
  Partials        7       7

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9d1c6d2...f9bcb84. Read the comment docs.

@vhiairrassary vhiairrassary deleted the vhiairrassary/move-webpack-cli-as-a-dependency branch September 20, 2019 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants