-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(client): fix tests for createSocketUrl #2323
fix(client): fix tests for createSocketUrl #2323
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2323 +/- ##
==========================================
- Coverage 93.92% 93.83% -0.09%
==========================================
Files 34 34
Lines 1284 1282 -2
Branches 366 365 -1
==========================================
- Hits 1206 1203 -3
- Misses 77 78 +1
Partials 1 1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks
CI fails
|
@hiroppy Isn't that the test which fails every now and then on Windows? Looking at the test history a failed |
Thanks! |
Motivation / Use-Case
follow up of #2303
the tests are incorrect because they did not prepend the
?
to the url. The parameter format should be like?http://0.0.0.0:8096&sockPort=8097&sockHost=localhost
replacing two
//
with one/
looks wrong an unused as mentioned in fix(client): don't override protocol for socket connection to 127.0.0.1 #2303