-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds an optional peer dependency on webpack-cli #2396
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2396 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 34 34
Lines 1297 1297
Branches 370 370
=======================================
Hits 1216 1216
Misses 79 79
Partials 2 2 Continue to review full report at Codecov.
|
Ping @evilebottnawi? |
@arcanis npm still not fixed bug about warning optional peer deps? |
They have fixed in November, so if you want to merge the other PR it'll be fine. If you're still a bit wary that's ok, that's why I opened this alternate PR: it only adds the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For Bugs and Features; did you add new tests?
Can publish a package with this PR and see if it actually works but these kind of fixes have been done multiple times to make Yarn 2 happy. Considering
webpack-dev-server
throws at runtime anyway ifwebpack-cli
is missing this shouldn't bother anyoneMotivation / Use-Case
Yarn 2 currently throws when using
webpack-dev-server
due to it trying to requirewebpack-cli
without declaring it anywhere in its dependencies:Breaking Changes
There is no breaking change for anyone - not even a warning for older package managers. This is a completely safe bugfix that will only impact Yarn users.
Additional Info
Supercedes: #2191
Documentation: https://next.yarnpkg.com/configuration/manifest#peerDependenciesMeta.optional