BREAKING CHANGE(https): migrate ca, cert, pfx, key, pfx-passphrase, and requestCert to https object

[hiroppy]

• This is a bugfix
• This is a feature
• This is a code refactor
• This is a test update
• This is a docs update
• This is a metadata update

For Bugs and Features; did you add new tests?

yes

Motivation / Use-Case

Migrate ca, cert, pfx, key, pfx-passphrase, and requestCert to https object.
These options are deleted from CLI.(accept https only

}
  https: {
    ca: string | Buffer;
    key: string | Buffer;
    pfx: string | Buffer;
    cert: string | Buffer;
    passphrase: string;
    requestCert: boolean;
  }
}

Breaking Changes

yes

Additional Info

[codecov]

Codecov Report

Merging #2564 into v4 will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##               v4    #2564   +/-   ##
=======================================
  Coverage   93.43%   93.43%           
=======================================
  Files          34       34           
  Lines        1309     1295   -14     
  Branches      369      363    -6     
=======================================
- Hits         1223     1210   -13     
+ Misses         83       82    -1     
  Partials        3        3           

Impacted Files	Coverage Δ
lib/utils/createConfig.js	95.78% <ø> (-0.41%)	⬇️
lib/Server.js	96.92% <100.00%> (+0.19%)	⬆️
lib/utils/addEntries.js	100.00% <100.00%> (ø)
lib/utils/routes.js	92.30% <100.00%> (ø)
lib/utils/updateCompiler.js	100.00% <100.00%> (ø)

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 308ee21...3a3aea3. Read the comment docs.

[alexander-akait]

/cc @Loonride

[knagaitsev]

webpack-dev-server/test/cli/cli.test.js

Line 76 in 375ab23

it('--https --cacert --pfx --key --cert --pfx-passphrase', (done) => {

We don't need this test. Also, has it always been the case that the CLI can run with unknown args?

[hiroppy]

We always accept any args like this.

$ npm run webpack-dev-server -- -a

> webpack-dev-server@3.10.3 webpack-dev-server /Users/hiroppy/webpack/webpack-dev-server
> node examples/run-example.js "-a"

And this test is poor.

[hiroppy]

@Loonride PTAL