Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Changed this.options.info to this.logger.info #2907

Closed
wants to merge 2 commits into from

Conversation

Xrumet
Copy link
Contributor

@Xrumet Xrumet commented Dec 4, 2020

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

No tests so far

Motivation / Use-Case

Cannot run dev server because of exception

Breaking Changes

No breaking change I think

Additional Info

@Xrumet Xrumet marked this pull request as ready for review December 4, 2020 11:07
@Xrumet
Copy link
Contributor Author

Xrumet commented Dec 4, 2020

Hi, @alexander-akait may you take a look on this PR and pickup/cherry pick this commit if it valid (I am not sure, but checked it and it works for me)

@codecov
Copy link

codecov bot commented Dec 4, 2020

Codecov Report

Merging #2907 (8e629d1) into master (b0ad9d8) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2907   +/-   ##
=======================================
  Coverage   92.54%   92.54%           
=======================================
  Files          37       37           
  Lines        1261     1261           
  Branches      334      334           
=======================================
  Hits         1167     1167           
  Misses         89       89           
  Partials        5        5           
Impacted Files Coverage Δ
lib/Server.js 94.88% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b0ad9d8...8e629d1. Read the comment docs.

@Xrumet Xrumet changed the title Changed this.options.info to this.logger.info fix:Changed this.options.info to this.logger.info Dec 4, 2020
@Xrumet Xrumet changed the title fix:Changed this.options.info to this.logger.info fix: Changed this.options.info to this.logger.info Dec 4, 2020
@alexander-akait
Copy link
Member

We need to add tests, I will look how to fix it

@Xrumet
Copy link
Contributor Author

Xrumet commented Dec 4, 2020

Thanks! I appreciate it!...

@Xrumet
Copy link
Contributor Author

Xrumet commented Dec 5, 2020

Created new PR to pass "commit message" check. Please see: #2910

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants