Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add WEBPACK_SERVE env variable #3000

Merged
merged 3 commits into from
Feb 9, 2021
Merged

feat: add WEBPACK_SERVE env variable #3000

merged 3 commits into from
Feb 9, 2021

Conversation

snitin315
Copy link
Member

@snitin315 snitin315 commented Feb 9, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

yes.

Motivation / Use-Case

Replaced by WEBPACK_SERVE in webpack-cli.

Breaking Changes

replace WEBPACK_DEV_SERVER with WEBPACK_SERVE.

Additional Info

no

Copy link
Member

@alexander-akait alexander-akait left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need to remove it, because some developers uses webpack-dev-server directly, let's rename to to WEBPACK_SERVE

@codecov
Copy link

codecov bot commented Feb 9, 2021

Codecov Report

Merging #3000 (d238743) into master (92a8aeb) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3000   +/-   ##
=======================================
  Coverage   92.39%   92.39%           
=======================================
  Files          37       37           
  Lines        1262     1262           
  Branches      326      326           
=======================================
  Hits         1166     1166           
  Misses         91       91           
  Partials        5        5           
Impacted Files Coverage Δ
lib/Server.js 94.88% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92a8aeb...0e19621. Read the comment docs.

@snitin315 snitin315 changed the title fix: remove WEBPACK_DEV_SERVER env variable feat: add WEBPACK_SERVE env variable Feb 9, 2021
alexander-akait
alexander-akait previously approved these changes Feb 9, 2021
@snitin315
Copy link
Member Author

Something wrong with webpack-4 CI 😞, investigating.

@snitin315 snitin315 closed this Feb 9, 2021
@snitin315 snitin315 reopened this Feb 9, 2021
@alexander-akait
Copy link
Member

@snitin315 Thanks for help, if you want the next PR - we need change static https://github.com/webpack/webpack-dev-server/blob/master/lib/utils/normalizeOptions.js#L18 to public (some tests need to change too, but it is very easy)

@snitin315
Copy link
Member Author

Will do next 👍.

hiroppy
hiroppy previously approved these changes Feb 9, 2021
@hiroppy
Copy link
Member

hiroppy commented Feb 9, 2021

hm, e2e seems fleky.

@alexander-akait
Copy link
Member

@snitin315 CI cache broken, we need install webpack v4

@alexander-akait alexander-akait merged commit e6fb023 into webpack:master Feb 9, 2021
@alexander-akait
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants