-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add WEBPACK_SERVE env variable #3000
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No need to remove it, because some developers uses webpack-dev-server
directly, let's rename to to WEBPACK_SERVE
Codecov Report
@@ Coverage Diff @@
## master #3000 +/- ##
=======================================
Coverage 92.39% 92.39%
=======================================
Files 37 37
Lines 1262 1262
Branches 326 326
=======================================
Hits 1166 1166
Misses 91 91
Partials 5 5
Continue to review full report at Codecov.
|
Something wrong with |
@snitin315 Thanks for help, if you want the next PR - we need change |
Will do next 👍. |
hm, e2e seems fleky. |
@snitin315 CI cache broken, we need install webpack v4 |
0e19621
Thanks |
For Bugs and Features; did you add new tests?
yes.
Motivation / Use-Case
Replaced by
WEBPACK_SERVE
inwebpack-cli
.Breaking Changes
replace
WEBPACK_DEV_SERVER
withWEBPACK_SERVE
.Additional Info
no