Skip to content

Conversation

alexander-akait
Copy link
Member

@alexander-akait alexander-akait commented Jul 12, 2021

  • This is a bugfix
  • This is a feature
  • This is a code refactor
  • This is a test update
  • This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

fix #3519

Motivation / Use-Case

I found it as breaking change, not fix

Breaking Changes

No

Additional Info

No

@codecov
Copy link

codecov bot commented Jul 12, 2021

Codecov Report

Merging #3524 (6a0fbe4) into master (a6501e6) will increase coverage by 0.49%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3524      +/-   ##
==========================================
+ Coverage   93.60%   94.09%   +0.49%     
==========================================
  Files          20       20              
  Lines        1282     1287       +5     
  Branches      423      426       +3     
==========================================
+ Hits         1200     1211      +11     
+ Misses         77       71       -6     
  Partials        5        5              
Impacted Files Coverage Δ
lib/servers/WebsocketServer.js 91.66% <100.00%> (+1.34%) ⬆️
lib/Server.js 93.08% <0.00%> (+0.46%) ⬆️
lib/utils/DevServerPlugin.js 99.27% <0.00%> (+2.18%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a6501e6...6a0fbe4. Read the comment docs.

@alexander-akait alexander-akait merged commit 9a1edc1 into master Jul 13, 2021
@alexander-akait alexander-akait deleted the chore-deps-update-ws branch July 13, 2021 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants