Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix undefined src attribute in scriptHost #394

Closed
wants to merge 1 commit into from
Closed

fix undefined src attribute in scriptHost #394

wants to merge 1 commit into from

Conversation

wrasdf
Copy link

@wrasdf wrasdf commented Feb 1, 2016

Hi there,

This is a fix for V1.14.1.

Thanks,
Kerry

This was referenced Feb 12, 2016
Closed
Closed
Closed
@SimenB SimenB mentioned this pull request Apr 12, 2016
Merged
@ptz0n ptz0n mentioned this pull request May 15, 2016
Closed
jhnns added a commit that referenced this pull request May 15, 2016
@jhnns
Merge pull request #447 from svsool/bug
4ecbae6 
fix bug when src attribute not defined on last script element
Merging this in favor of #394
@jhnns
Copy link
Member

jhnns commented May 15, 2016

Hi, thanks for your contribution. We've merged #447 which was almost the same change.

However, now I think we should rather fix the underlying problem as discussed in #117 before publishing this.

@jhnns jhnns closed this May 15, 2016
@tonyg101 tonyg101 mentioned this pull request Jul 29, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wrasdf @jhnns