fix: make webpack optional peer dependency #4778
Conversation
hardfist
requested review from
alexander-akait,
hiroppy,
snitin315 and
anshumanv
as code owners
|
|
| }, | ||
| "webpack": { | ||
| "optional": true | ||
| } |
There was a problem hiding this comment.
You may also want to remove it from the peerDependenciesfield above
webpack-dev-server/package.json
Line 137 in 4e84607
There was a problem hiding this comment.
if we remove webpack from peerDependencies it would mean any webpack version would be ok for webpack-dev-server but webpack-dev-server did require specific webpack version according to the documentation of https://pnpm.io/next/package_json#peerdependenciesmetaoptional
There was a problem hiding this comment.
Yeah, we still need versions, in theory this PR can break a code for some inattentive developers (which ignored warnings from package managers), if you don't have webpack in dependcies and rely on the new behaviour of npm (autoinstall peer deps), but it should be fixed on their side, because you should always list of you dependecies
Codecov ReportPatch and project coverage have no change.
Additional details and impacted files@@ Coverage Diff @@
## master #4778 +/- ##
=======================================
Coverage 92.05% 92.05%
=======================================
Files 16 16
Lines 1662 1662
Branches 622 622
=======================================
Hits 1530 1530
Misses 121 121
Partials 11 11 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
For Bugs and Features; did you add new tests?
No, not easy to test in this repo
Motivation / Use-Case
fixes #4776
Breaking Changes
No
Additional Info