Skip to content

Conversation

@cmw-big
Copy link

@cmw-big cmw-big commented Mar 30, 2023

  • [ x] This is a bugfix
  • [ x] This is a feature
  • [ x] This is a code refactor
  • [ x] This is a test update
  • [ x] This is a docs update
  • This is a metadata update

For Bugs and Features; did you add new tests?

Motivation / Use-Case

"When I was reading lib/Server.js, I noticed that the type name was duplicated between line 199 and line 189, so I thought about submitting a PR."

Breaking Changes

Additional Info

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Mar 30, 2023

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: cmw-big / name: chengmingwang (420cb5f)

@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -1.51 ⚠️

Comparison is base (22fb1e5) 91.83% compared to head (ee5488f) 90.33%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4796      +/-   ##
==========================================
- Coverage   91.83%   90.33%   -1.51%     
==========================================
  Files          16       16              
  Lines        1665     1665              
  Branches      624      624              
==========================================
- Hits         1529     1504      -25     
- Misses        125      147      +22     
- Partials       11       14       +3     
Impacted Files Coverage Δ
lib/Server.js 91.51% <ø> (-2.03%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@cmw-big cmw-big requested review from alexander-akait and removed request for anshumanv, hiroppy and snitin315 March 30, 2023 16:10
@alexander-akait alexander-akait mentioned this pull request Mar 30, 2023
6 tasks
@alexander-akait
Copy link
Member

typescript has strange bugs with type generation, I send an another PR to fix it - #4797, anyway big thank you for this PR

@alexander-akait
Copy link
Member

@cmw-big Anyway, big thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants