fix(perf): reduced initial start time #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
hiroppy,
snitin315 and
anshumanv
as code owners
alexander-akait
commented
Apr 15, 2023
| @@ -355,7 +381,7 @@ class Server { | |||
| */ | |||
| static internalIPSync(family) { | |||
| try { | |||
| const { gateway } = defaultGateway[family].sync(); | |||
| const { gateway } = require("default-gateway")[family].sync(); | |||
There was a problem hiding this comment.
We use only one method or async or sync, so it is fine to use require
There was a problem hiding this comment.
Also we don't it when a developer provide IP, so avoid it for some cases
alexander-akait
commented
Apr 15, 2023
| }; | ||
| }; | ||
|
|
||
| const getExpress = memoize(() => require("express")); |
There was a problem hiding this comment.
Yeah, we always run express, but let's do it lazy
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4818 +/- ##
==========================================
+ Coverage 90.45% 92.10% +1.65%
==========================================
Files 16 16
Lines 1665 1673 +8
Branches 624 625 +1
==========================================
+ Hits 1506 1541 +35
+ Misses 145 121 -24
+ Partials 14 11 -3
... and 1 file with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
No need
Motivation / Use-Case
Start faster
Breaking Changes
No
Additional Info
No