Handle missing src attribute on unused last script
#515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a bug introduced in 3d3c000, in the case where: - `__resourceQuery` is set, and - The last script tag on the page has no `src` attribute Previously the script tag's `src` attribute was accessed lazily only if `__resourceQuery` was not defined. The last script on the page may not be the script that loaded webpack-dev-server. This can happen, for example, with the use of an asynchronous loader such as LABjs.
|
Oh, this is basically equivalent to #447. Just need that applied in |
gigabo
added a commit
to gigabo/react-server
that referenced
this pull request
Jun 30, 2016
This is new enough to pass `nsp check`, but old enough to not suffer from [this bug](webpack/webpack-dev-server#515).
gigabo
added a commit
to gigabo/react-server
that referenced
this pull request
Jun 30, 2016
This is new enough to pass `nsp check`, but old enough to not suffer from [this bug](webpack/webpack-dev-server#515). This fixes redfin#311.
gigabo
added a commit
to redfin/react-server
that referenced
this pull request
Jun 30, 2016
This is new enough to pass `nsp check`, but old enough to not suffer from [this bug](webpack/webpack-dev-server#515). This fixes #311.
davidalber
pushed a commit
to davidalber/react-server
that referenced
this pull request
Jul 24, 2016
This is new enough to pass `nsp check`, but old enough to not suffer from [this bug](webpack/webpack-dev-server#515). This fixes redfin#311.
|
I'll make sure to backport this for the next v1 release. Also see #363. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This fixes a bug introduced in 3d3c000, in the case where:
__resourceQueryis set, andsrcattributePreviously the script tag's
srcattribute was accessed lazily only if__resourceQuerywas not defined. The last script on the page may not be the script that loaded webpack-dev-server. This can happen, for example, with the use of an asynchronous loader such as LABjs.I've pointed this PR at master, but it is based on
v1.14.1, which is the latest non-beta release. We are not on webpack>=2.0.3-beta <3, so we would need this bug fix on the^1.14.1range. How are you handling patches there?Thanks,
Bo