Fix HistoryApiFallback when publicPath is set #518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently HistoryApiFallback does not work properly when publicPath as it redirects request to /index.html which gives as it does not exist, instead we should redirect to publicPath (which redirects to publicPath/index.html). Fixes webpack#216
|
This is kinda tricky stuff, and I'm not sure if it's always the case that you want to use the Do other people have this problem? |
|
Closing for now. #216 was already fixed by another PR. In the docs it's also documented that you need to use a custom index when using We could theoretically do this automatically, but this is a breaking change that I only want to do if more people have this problem. Will revisit this PR when that happens. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently HistoryApiFallback does not work properly when publicPath as it redirects request to
/index.htmlwhich gives as it does not exist, instead we should redirect to publicPath (which redirects topublicPath/index.html).Fixes #216