feat: http2 support for connect compatibility application
#5267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexander-akait
requested review from
hiroppy,
snitin315 and
anshumanv
as code owners
alexander-akait
force-pushed
the
http2-support
branch
from
68eefa4 to
56a6dca
Compare
alexander-akait
force-pushed
the
http2-support
branch
from
56a6dca to
ff7f35a
Compare
|
All works fine except a deprecation warning - pillarjs/finalhandler#45, we can fix it here, I want to make a small patch and when it will be resolved we remove it |
3 tasks
levrik
reviewed
Mar 31, 2025
| @@ -2946,6 +2969,8 @@ class Server { | |||
| */ | |||
| const allHeaders = []; | |||
|
|
|||
| allHeaders.push({ key: "X_TEST", value: "TEST" }); | |||
There was a problem hiding this comment.
I just wondered after upgrading to webpack-dev-server 5.2.1 where this header is coming from and could track it down to this PR. Looks like it's there for quite some time already and I simply didn't notice until now. Does this serve any purpose or is it maybe a left-over from some testing?
There was a problem hiding this comment.
Looks like we I don't see it when merging, let's fix
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For Bugs and Features; did you add new tests?
Yes
Motivation / Use-Case
Allow to use
http2withconnect,expressstill doesn't support http2Breaking Changes
No
Additional Info
No