Fix issue with defer/async/empty script src #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Closed

vutran wants to merge 1 commit into webpack:master from vutran:fix-issue-381

vutran commented Jul 24, 2016

This PR fixes issue #381 for v1.14.1.

When you have a page with a script tag with no src attribute or if the script is async, it's trying to call .replace() from a non-string.

This patch should also fix the loading issues for facebook/create-react-app/issues/134


          Fix issue with defer/async/empty script src

856c420

Member

SpaceK33z commented Aug 21, 2016

Closing in favor of #496, which provides a cleaner solution.

SpaceK33z closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet