Allow --open option to specify the browser to use #825

frankwinter · 2017-03-03T19:17:30Z

Fixes #753

An additional parameter for the --open option will pass it to opn. For example webpack-dev-server --open 'Google Chrome' will open chrome browser. When the parameter is omitted the systems default browser starts up as usual.

jsf-clabot · 2017-03-03T19:17:30Z

All committers have signed the CLA.

…wser

codecov · 2017-03-11T09:36:24Z

Codecov Report

Merging #825 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #825   +/-   ##
=======================================
  Coverage   73.17%   73.17%           
=======================================
  Files           5        5           
  Lines         451      451           
  Branches      143      143           
=======================================
  Hits          330      330           
  Misses        121      121

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf5dda8...a230754. Read the comment docs.

SpaceK33z · 2017-03-11T12:47:42Z

bin/webpack-dev-server.js

+		if(typeof options.open === "string")
+			params.push({ app: options.open });
+
+		open(...params).catch(function() {


Array spread doesn't seem to work in Node v4.

SpaceK33z

This doesn't work because yargs still treats the open command as a boolean. On line 89 you should change the type to string.

…wser

sergeymorkovkin · 2017-07-05T14:12:34Z

Any chances to have it merged? :)

shellscape · 2017-07-10T13:20:20Z

@sergeymorkovkin we need tests added to this PR for the new option. it'll become too difficult to manually test for each new version otherwise. @frankwinter needs to add that and resolve the conflicts recently introduced for this to get merged I'm afraid.

sergeymorkovkin · 2017-07-10T15:19:06Z

@shellscape Got it. Thanks for an update. If you think I could do this, please let me known.

…into open-specific-browser

shellscape

You'll want to add .idea to .gitignore and remove all of those files. You've got some whitespace issues as well on line 341

michael-ciniawsky · 2017-07-10T20:56:01Z

.idea/inspectionProfiles/Project_Default.xml

@@ -0,0 +1,12 @@
+<component name="InspectionProjectProfileManager">


Please blacklist and remove all the IDE specific files .idea/*

michael-ciniawsky · 2017-07-10T20:56:38Z

bin/webpack-dev-server.js

+
+	if(argv["open"] || argv["open-page"]) {
+		if(argv["open"] && argv["open"] !== "") {
+      options.open = argv["open"];


Indendation seems to be off here

shellscape · 2017-07-11T02:07:50Z

@frankwinter you'll have to remove the package-lock.json as well.

frankwinter · 2017-07-11T08:30:59Z

Sorry, please excuse the clumsy workflow.. It's my first contribution on a forked github-project :-/

shellscape

this still needs some help before we can merge it

shellscape · 2017-07-11T11:52:00Z

bin/webpack-dev-server.js

-		open(uri + options.openPage).catch(function() {
-			console.log("Unable to open browser. If you are running in a headless environment, please do not use the open flag.");
-		});
+		if(argv["open"] && argv["open"] !== "") {


you're already performing this check on line 340, and on 461 you're checking the truthy value of options.open which is set on 341 and 343. shouldn't this be if(typeof options.open === "string")?

shellscape · 2017-07-11T11:54:18Z

bin/webpack-dev-server.js

@@ -337,7 +337,11 @@ function processOptions(wpOpt) {
 		options.disableHostCheck = true;

 	if(argv["open"] || argv["open-page"]) {
-		options.open = true;
+		if(argv["open"] && argv["open"] !== "") {


you've changed the type for yargs to string on line 95, and an empty string is falsey - is there a reason you're checking the truthy value of args["open"] and also checking that it's not empty?

shellscape · 2017-07-11T12:29:14Z

bin/webpack-dev-server.js

-			console.log("Unable to open browser. If you are running in a headless environment, please do not use the open flag.");
-		});
+		if(argv["open"] && argv["open"] !== "") {
+			open(uri + options.openPage, { app: options.open }).catch(function() {


not a fan of two nearly identical calls to open and subsequent logging. should be something like this:

(this is pseudo code, don't copy and paste it)

var openOptions = {}; var openMessage = "Unable to open browser"; if (typeof options.open === "string") { openOptions = { app: options.open }; openMessage =+ " : " + options.open; } open(uri + options.openPage, openOptions).catch(function () { console.log(openMessage + "If you are running in a headless environment, please do not use the open flag."); });

frankwinter · 2017-07-11T16:51:18Z

If you call —open without a value argv["open“] will contain an empty string and options.open is going to be undefined. Currently I don’t know if this can be managed somewhere else..

…

Am 11.07.2017 um 17:48 schrieb Andrew Powell ***@***.***>: @shellscape commented on this pull request. In bin/webpack-dev-server.js <#825 (comment)>: > options.open = true; - options.openPage = argv["open-page"] || ""; + options.openPage = argv["open-page"]; + } + + if(typeof argv["open"] !== "undefined") { why not if(argv["open"]) { options.open = argv["open"] || true; } — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#825 (review)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AMvJZksMcp_dOe6I8zOOArmfJGsk4A0Dks5sM5kygaJpZM4MSo_g>.

mirages · 2017-08-08T08:34:53Z

How to set the parameter in webpack.config.js file? My configure likes that:

devServer: {
    port: '8081'
    ,compress: true
    ,watchContentBase: true
    ,open: 'chrome'
    ,openPage: 'views/index/'
}

but it doesn't work!!! And throw an error:

shellscape · 2017-08-08T12:09:49Z

@shuijingleihen pull request discussions are not forums for support. Please ask questions on StackOverflow or the webpack Gitter (https://gitter.im/webpack/webpack).

mirages · 2017-08-08T12:27:23Z

@shellscape Oh sorry, I thought it was an issue, thank you for your reminding！

tomchentw · 2017-08-23T05:48:11Z

Any progress/changes on this PR? I'd love to help!

shellscape · 2017-08-23T12:39:33Z

@tomchentw I think we're good. @frankwinter needs to resolve the conflicts that popped up. I'll be on vaca until 8/27 but can merge when I'm back.

changes made as requested

tomchentw · 2017-08-30T04:07:50Z

WOW!

zigang93 · 2018-01-09T04:17:32Z

devServer: {
port: '8081'
,compress: true
,open: 'firefox'
}

is working! thanks.
Btw, should we update the doc on https://webpack.js.org/configuration/dev-server/#devserver-open ?

it should giving example of allow to use string and Boolean :)

crowscript · 2019-03-19T14:55:09Z

This solves the issue.
In package.json:
"start": "webpack-dev-server --config webpack.dev.js --open chrome",

In webpack.config.js:

devServer: {
        ...
        open: 'chrome'
      },

jdavidferreira · 2019-08-22T20:28:51Z

How can I open Firefox Developer Edition with the open property?

Add optionally browser parameter to --open

30c4fbd

frankwinter added 3 commits March 3, 2017 21:57

Fix code style issues

b5f064e

Fix last code style issue

5b7f8e0

Merge remote-tracking branch 'upstream/master' into open-specific-bro…

15ec8d3

…wser

SpaceK33z reviewed Mar 11, 2017

View reviewed changes

SpaceK33z previously requested changes Mar 11, 2017

View reviewed changes

frankwinter added 3 commits March 14, 2017 09:40

Replace array spread

75ef717

Merge remote-tracking branch 'upstream/master' into open-specific-bro…

d78c1ae

…wser

Merge remote-tracking branch 'upstream/master' into open-specific-bro…

52ad1a2

…wser

michael-ciniawsky approved these changes Jul 5, 2017

View reviewed changes

frankwinter added 2 commits July 10, 2017 22:26

Fix conflicts

f04bba3

Merge branch 'master' of https://github.com/webpack/webpack-dev-server …

8b64374

…into open-specific-browser

shellscape suggested changes Jul 10, 2017

View reviewed changes

michael-ciniawsky suggested changes Jul 10, 2017

View reviewed changes

frankwinter added 3 commits July 10, 2017 23:05

Fix whitespace issue

4d65ef1

Add .idea to gitignore and remove files

2c32834

Fix whitespaces

682d47e

Ignore and remove package-lock.json

a18ae9c

shellscape suggested changes Jul 11, 2017

View reviewed changes

refactor argument composition

d3a46ae

frankwinter and others added 2 commits August 27, 2017 17:26

Merge branch 'master' into open-specific-browser

9ca67c9

Merge branch 'master' into open-specific-browser

cb31c90

shellscape approved these changes Aug 30, 2017

View reviewed changes

shellscape changed the base branch from master to abandoned-pull-requests August 30, 2017 02:06

shellscape changed the title ~~Add optionally browser parameter to --open~~ Allow --open option to specify the browser to use Aug 30, 2017

shellscape changed the base branch from abandoned-pull-requests to master August 30, 2017 02:08

shellscape added 2 commits August 29, 2017 22:10

removing trailing spaces

b847645

improve open option description to match pr

a230754

shellscape merged commit f00fcb3 into webpack:master Aug 30, 2017

frankwinter deleted the open-specific-browser branch August 30, 2017 17:26

tonyg101 mentioned this pull request Nov 26, 2023

[Snyk] Fix for 1 vulnerabilities signal-noise/webpack-dev-server#7

Open

wizbit mentioned this pull request Dec 20, 2023

[Snyk] Fix for 16 vulnerabilities signal-noise/webpack-dev-server#10

Open

tonyg101 mentioned this pull request Mar 22, 2024

[Snyk] Fix for 2 vulnerabilities signal-noise/webpack-dev-server#12

Open

tonyg101 mentioned this pull request May 14, 2024

[Snyk] Security upgrade chokidar from 2.1.8 to 3.0.0 signal-noise/webpack-dev-server#14

Open

joeawillis mentioned this pull request May 22, 2024

[Snyk] Fix for 2 vulnerabilities signal-noise/webpack-dev-server#15

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow --open option to specify the browser to use #825

Allow --open option to specify the browser to use #825

frankwinter commented Mar 3, 2017 •

edited

Loading

jsf-clabot commented Mar 3, 2017 •

edited

Loading

codecov bot commented Mar 11, 2017 •

edited

Loading

SpaceK33z Mar 11, 2017

SpaceK33z left a comment

sergeymorkovkin commented Jul 5, 2017

shellscape commented Jul 10, 2017 •

edited

Loading

sergeymorkovkin commented Jul 10, 2017

shellscape left a comment

michael-ciniawsky Jul 10, 2017

michael-ciniawsky Jul 10, 2017

shellscape commented Jul 11, 2017

frankwinter commented Jul 11, 2017

shellscape left a comment

shellscape Jul 11, 2017

shellscape Jul 11, 2017

shellscape Jul 11, 2017

frankwinter commented Jul 11, 2017 via email

mirages commented Aug 8, 2017

shellscape commented Aug 8, 2017

mirages commented Aug 8, 2017

tomchentw commented Aug 23, 2017

shellscape commented Aug 23, 2017

tomchentw commented Aug 30, 2017

zigang93 commented Jan 9, 2018

crowscript commented Mar 19, 2019

jdavidferreira commented Aug 22, 2019

		@@ -0,0 +1,12 @@
		<component name="InspectionProjectProfileManager">

Allow --open option to specify the browser to use #825

Allow --open option to specify the browser to use #825

Conversation

frankwinter commented Mar 3, 2017 • edited Loading

jsf-clabot commented Mar 3, 2017 • edited Loading

codecov bot commented Mar 11, 2017 • edited Loading

Codecov Report

SpaceK33z Mar 11, 2017

Choose a reason for hiding this comment

SpaceK33z left a comment

Choose a reason for hiding this comment

sergeymorkovkin commented Jul 5, 2017

shellscape commented Jul 10, 2017 • edited Loading

sergeymorkovkin commented Jul 10, 2017

shellscape left a comment

Choose a reason for hiding this comment

michael-ciniawsky Jul 10, 2017

Choose a reason for hiding this comment

michael-ciniawsky Jul 10, 2017

Choose a reason for hiding this comment

shellscape commented Jul 11, 2017

frankwinter commented Jul 11, 2017

shellscape left a comment

Choose a reason for hiding this comment

shellscape Jul 11, 2017

Choose a reason for hiding this comment

shellscape Jul 11, 2017

Choose a reason for hiding this comment

shellscape Jul 11, 2017

Choose a reason for hiding this comment

frankwinter commented Jul 11, 2017 via email

mirages commented Aug 8, 2017

shellscape commented Aug 8, 2017

mirages commented Aug 8, 2017

tomchentw commented Aug 23, 2017

shellscape commented Aug 23, 2017

tomchentw commented Aug 30, 2017

zigang93 commented Jan 9, 2018

crowscript commented Mar 19, 2019

jdavidferreira commented Aug 22, 2019

frankwinter commented Mar 3, 2017 •

edited

Loading

jsf-clabot commented Mar 3, 2017 •

edited

Loading

codecov bot commented Mar 11, 2017 •

edited

Loading

shellscape commented Jul 10, 2017 •

edited

Loading