-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't output startup info if quiet is set to true #970
Conversation
Codecov Report
@@ Coverage Diff @@
## master #970 +/- ##
=======================================
Coverage 72.13% 72.13%
=======================================
Files 4 4
Lines 463 463
Branches 139 139
=======================================
Hits 334 334
Misses 129 129 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we've already got the quiet
option, and it's apparently supposed to do what you're attempting to do with noInfo
see:
webpack-dev-server/lib/optionsSchema.json
Line 290 in 7b3a42a
"quiet": { |
I'd say use that option here instead.
@shellscape but then the |
It might be there for legacy reasons, not entirely sure. |
What kind of change does this PR introduce?
Use
quiet
option to decide if webpack should print startup info or not.Did you add or update the
examples/
?No
Summary
As stated by @jonathanconway in webpack/webpack#1191 there's no way to fully disable all logs. Also, I've been investigating and didn't find where the
noInfo
option is used so I decided to use it to disable the startup info.Does this PR introduce a breaking change?
No
Other information