Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/rwd #203

Merged
merged 14 commits into from
Oct 2, 2016
Merged

Feature/rwd #203

merged 14 commits into from
Oct 2, 2016

Conversation

oliverturner
Copy link
Contributor

Basic responsiveness added:

  • Viewport metatag
  • An additional breakpoint + mixin to adapt styles to increasing resolutions
  • Basic mobile menu

Remaining issues:

  • The absence of accessible state on the parent means that the menu persists on route changes
  • It's unclear to me how to render the sections/pages, since the page objects don't contain a reference to section items

Oliver Turner and others added 14 commits September 27, 2016 18:54
…via Lifecycle scripts included in webpack.js.org:

  start
    node ./bootstrap.js
  test
    npm run lint

available via `npm run-script`:
  build
    node ./bootstrap.js && npm run sitemap && echo webpack.js.org > build/CNAME
  deploy
    gh-pages -d build
  lint
    run-s lint:*
  lint:js
    eslint . --ext .js --ext .jsx
  lint:md
    eslint . --ext .md
  lint:markdown
    markdownlint --config ./.markdownlintrc **/*.md *.md ./content/**/*.md
  lint:social
    alex ./**/*.md
  lint:prose
    cp .proselintrc ~/ && proselint
  sitemap
    cd build && sitemap-static --prefix=https://webpack.js.org/ > sitemap.xml
@oliverturner oliverturner mentioned this pull request Oct 2, 2016
3 tasks
Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this looks awesome @bebraw would you mind brushing this over. I think the limitations listed could be iterated on, personally I'd love to see this in ASAP for the sake of the responsiveness.

Also could you provide a few screenshots of the view ports?

@skipjack
Copy link
Collaborator

skipjack commented Oct 2, 2016

Just pulled and started yours up locally, @TheLarkInn here's one:

screen shot 2016-10-02 at 2 21 10 pm

@oliverturner I think this looks great, thank you! There are a few other tweaks we can make but this is a big first step and I agree with @TheLarkInn that we should get this in soon.

@oliverturner I can take a stab at the Sidebar page sections tonight. @bebraw and I had discussed this being at the antwar level before, but using the same function in the markdown.js utility we can parse the anchor data out from each page's content and generate those links.

@oliverturner
Copy link
Contributor Author

localhost-3000-concepts ipad 1
localhost-3000-concepts ipad
localhost-3000-concepts iphone 5 1
localhost-3000-concepts iphone 5
localhost-3000-concepts iphone 6 1
localhost-3000-concepts iphone 6

@bebraw bebraw merged commit 781c1fc into webpack:develop Oct 2, 2016
@bebraw
Copy link
Contributor

bebraw commented Oct 2, 2016

@oliverturner Can you open separate issues for the bits you need so I will remember to tackle those? Thanks!

@oliverturner
Copy link
Contributor Author

oliverturner commented Oct 2, 2016

@gregvenech @bebraw @TheLarkInn Glad I could help!

@gregvenech

I can take a stab at the Sidebar page sections tonight.

That would be completely awesome 👍

@bebraw

Can you open separate issues for the bits you need so I will remember to tackle those?

Absolutely. Thanks for the earlier guidance!

@oliverturner oliverturner deleted the feature/rwd branch October 2, 2016 20:08
@oliverturner oliverturner restored the feature/rwd branch October 2, 2016 20:09
@skipjack skipjack mentioned this pull request Oct 5, 2016
3 tasks
sallar pushed a commit to sallar/webpack.js.org that referenced this pull request Oct 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants