Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more configuration documentation for DevServer #204

Merged
merged 3 commits into from
Oct 2, 2016

Conversation

SpaceK33z
Copy link
Member

@SpaceK33z SpaceK33z commented Oct 2, 2016

I added much more documentation to the DevServer configuration page. Some of my additions are inspired by the existing docs, but most of it is completely rewritten.

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. @gaearon @sokra do you see anything missing that should be added. This is a nice addition so far.

@SpaceK33z
Copy link
Member Author

SpaceK33z commented Oct 2, 2016

Discussed the documentation of the webpack-dev-middleware options with @TheLarkInn a bit, and we think it's best to document these on the same page. Every option that is compatible with both will get a 🔑 emoji (which will be explained in the introduction). Maybe we'll figure out a smarter way, but at least I can continue with documenting these options then :).

I'll try to finish documenting this today, so please wait to merge.

@SpaceK33z
Copy link
Member Author

Okay, done! This page now documents webpack-dev-server AND webpack-dev-middleware. A lot of stuff that wasn't even documented before has been added :). Ready for review.

Copy link
Member

@TheLarkInn TheLarkInn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @bebraw let's cut a release.

@TheLarkInn TheLarkInn merged commit ba74e81 into webpack:develop Oct 2, 2016
@TheLarkInn
Copy link
Member

Thank you @SpaceK33z

KyleAMathews pushed a commit to KyleAMathews/webpack.js.org that referenced this pull request Oct 4, 2016
* Add more configuration documentation for DevServer

* Document configuration from webpack-dev-server

* Various small text tweaks.
sallar pushed a commit to sallar/webpack.js.org that referenced this pull request Oct 19, 2016
* Add more configuration documentation for DevServer

* Document configuration from webpack-dev-server

* Various small text tweaks.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants