docs(sideEffects): documented rule and updated tree-shaking terms #2110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
montogeek
approved these changes
Jun 14, 2018
dhruvdutt
approved these changes
Jun 14, 2018
|
Looks like the latest Travis build failed because it triggered the Github API rate limit, not sure if I can start it off again. |
|
@montogeek ^ is that CI build fail issue resolved in |
|
@montogeek seems it didn't work, right? |
|
@byzyk No, it doesn't, It seems I am not reading TravisCI env variable correctly. Will debug |
|
Looking like the latest build was able to complete successfully 🤞 |
|
Thank you |
|
Thank you for the merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello! 👋
sideEffectsproperty in package.jsonsideEffectsrule in module.md (though I'm not familiar with its use)Would appreciate any feedback! Thank you!