docs(dev-server): New http2 option #2923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
EugeneHlushko
requested changes
Apr 8, 2019
|
|
||
| `boolean` | ||
|
|
||
| Serve over HTTP/2 using [spdy](https://www.npmjs.com/package/spdy). This option is ignored for Node 10.0.0 and above, as spdy is broken for those versions. The dev server will migrate over to Node's built-in HTTP/2 once Express supports it. |
There was a problem hiding this comment.
Suggested change
| Serve over HTTP/2 using [spdy](https://www.npmjs.com/package/spdy). This option is ignored for Node 10.0.0 and above, as spdy is broken for those versions. The dev server will migrate over to Node's built-in HTTP/2 once Express supports it. | |
| Serve over HTTP/2 using [spdy](https://www.npmjs.com/package/spdy). This option is ignored for Node 10.0.0 and above, as spdy is broken for those versions. The dev server will migrate over to Node's built-in HTTP/2 once [Express](https://expressjs.com/) supports it. |
wizardofhogwarts
suggested changes
Apr 8, 2019
There was a problem hiding this comment.
@Loonride review the suggested changes. Also, IMO comments by @EugeneHlushko are appearing to be valid.
| }; | ||
| ``` | ||
|
|
||
| Usage via the CLI |
There was a problem hiding this comment.
Suggested change
| Usage via the CLI | |
| Usage via CLI |
sounds better to me
| webpack-dev-server --http2 | ||
| ``` | ||
|
|
||
| To pass your own certificate via the CLI use the following options |
There was a problem hiding this comment.
Suggested change
| To pass your own certificate via the CLI use the following options | |
| To pass your own certificate via CLI, use the following options |
EugeneHlushko
approved these changes
Apr 10, 2019
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
describe your changes...
Issue: #2922
I documented the new
devServer.http2option.httpsoption