Update hot-reload example to use require() #304
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was the only way I could get it to work, migrating from webpack 1 on a fairly simple project. Also, seems logical since you either need to render the new reference to App, or re-require it on every `render` call (see gaearon/react-hot-loader#243 (comment))
|
|
|
@jmreidy, can you confirm this? |
dtinth
suggested changes
Nov 6, 2016
| const render = () => { | ||
| ReactDOM.render( | ||
| <AppContainer> | ||
| <App/> | ||
| { require('./components/App').default } |
There was a problem hiding this comment.
I think the code will be more clear if we did not inline it:
const App = require('./components/App').default
ReactDOM.render(
<AppContainer>
<App />Also, require('./components/App').default results in a React Component instead of a React Element, so I believe it doesn’t work unless you change it to this:
{React.createElement(require('./components/App').default)}
|
In webpack 2 it should work with If it doesn't work this way, it's a webpack bug. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the only way I could get it to work, migrating from webpack 1 on a fairly simple project.
Also, seems logical since you either need to render the new reference to App, or re-require it on every
rendercall (see gaearon/react-hot-loader#243 (comment))