Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/replace proselint with vale #4195

Merged
merged 11 commits into from
Nov 24, 2020

Conversation

chenxsan
Copy link
Member

@chenxsan chenxsan commented Nov 22, 2020

closes #4162

TODO

  • replace proselint with vale
  • fix some errors in markdown files
  • remove Python requirements

Proselint job ran for 2m 46s before according to https://github.com/webpack/webpack.js.org/runs/1436990385?check_suite_focus=true, and now only 45s https://github.com/webpack/webpack.js.org/runs/1437588188?check_suite_focus=true

@vercel
Copy link

vercel bot commented Nov 22, 2020

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/6pd18rmgv
✅ Preview: https://webpack-js-org-git-feature-replace-proselint-with-vale.webpack-docs.now.sh

@chenxsan chenxsan marked this pull request as ready for review November 22, 2020 06:25
@chenxsan chenxsan merged commit 25894d2 into webpack:master Nov 24, 2020
@chenxsan chenxsan deleted the feature/replace-proselint-with-vale branch November 24, 2020 11:15
@montogeek
Copy link
Member

Does it need all this configuration?

@montogeek montogeek added Documentation Grammar A pull request focused on grammar correction. Infrastructure SEO Site Structure labels Jan 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Documentation Grammar A pull request focused on grammar correction. Infrastructure SEO Site Structure
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace proselint with vale
2 participants