-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/replace proselint with vale #4195
Merged
chenxsan
merged 11 commits into
webpack:master
from
chenxsan:feature/replace-proselint-with-vale
Nov 24, 2020
Merged
Feature/replace proselint with vale #4195
chenxsan
merged 11 commits into
webpack:master
from
chenxsan:feature/replace-proselint-with-vale
Nov 24, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This pull request is being automatically deployed with Vercel (learn more). 🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/6pd18rmgv |
Does it need all this configuration? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Documentation
Grammar
A pull request focused on grammar correction.
Infrastructure
SEO
Site Structure
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #4162
TODO
Proselint job ran for 2m 46s before according to https://github.com/webpack/webpack.js.org/runs/1436990385?check_suite_focus=true, and now only 45s https://github.com/webpack/webpack.js.org/runs/1437588188?check_suite_focus=true