upgrade html-loader

[chenxsan]

No description provided.

[vercel]

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/webpack-docs/webpack-js-org/5u3tppaw3
✅ Preview: https://webpack-js-org-git-fork-chenxsan-feature-upgrade-html-loader.webpack-docs.vercel.app

[alexander-akait]

I recommend to wait new version of html-webpack-plugin, there are other small bugs

[chenxsan]

@alexander-akait I'm checking if the new feature can fix the problem. Seems not.

[chenxsan]

Error detail:

20:31:51.240 | ERROR in ReferenceError: URL is not defined
-- | --
20:31:51.240 | at evalmachine.<anonymous>:76585:46
20:31:51.240 | at evalmachine.<anonymous>:76586:13
20:31:51.240 | at evalmachine.<anonymous>:76713:12
20:31:51.241 | at webpackUniversalModuleDefinition (evalmachine.<anonymous>:3:20)
20:31:51.241 | at evalmachine.<anonymous>:10:3
20:31:51.241 | at Script.runInContext (vm.js:143:18)
20:31:51.241 | at Script.runInNewContext (vm.js:148:17)
20:31:51.241 | at module.exports (/vercel/workpath0/node_modules/eval/eval.js:73:12)
20:31:51.241 | at /vercel/workpath0/node_modules/static-site-generator-webpack-plugin/index.js:42:22
20:31:51.241 | at fn (/vercel/workpath0/node_modules/webpack/lib/Compilation.js:401:9)
20:31:51.241 | ssg (webpack 5.23.0) compiled with 1 error in 55120 ms

[alexander-akait]

Bug in static-site-generator-webpack-plugin too

[alexander-akait]

Here example how to fix it webpack/webpack#12695

[alexander-akait]

compiler.options.module.defaultRules.push({
  compiler: /mini-css /, // or whatever the name prefix for mini-css child compilers is
  parser: { url: "relative" }
})

[chenxsan]

Here example how to fix it webpack/webpack#12695

I believe I've added it. See https://github.com/webpack/webpack.js.org/pull/4629/files#diff-0e2cd931e69e0a20bcaabcf809440adb57cefc39f36a161bad867d039de6dc9c.

[chenxsan]

Bug in static-site-generator-webpack-plugin too

Seems to be a problem from the eval package:

And here's the code webpack generated:

Unfortunately both eval and static-site-generator-webpack-plugin are unmaintained now.

[chenxsan]

I might found the culprit nodejs/node#28823.

Assigning URL fix our problem:

[chenxsan]

So far it works. But in the end we might need to replace static-site-generator-webpack-plugin with something else because:

1. it's no longer maintained
2. it modifies compilation.assets which will be a problem because of:

[DEP_WEBPACK_COMPILATION_ASSETS] DeprecationWarning: Compilation.assets will be frozen in future, all modifications are deprecated

[alexander-akait]

it's no longer maintained

We can move this plugin inside webpack.js.org repo and update old API

[chenxsan]

It surprised me, but eval author had merged the fix.