-
-
Notifications
You must be signed in to change notification settings - Fork 3.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update docs for the extends option #6794
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PR not to be merged until a new release is done for webpack-cli |
@burhanuday is attempting to deploy a commit to the Webpack Docs Team on Vercel. A member of the Team first needs to authorize it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR. I'll review this by today/tomorrow.
One thing is left to be added. This feature will be supported after the release of webpack and webpack-cli |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall, added a few suggestions. Would be great to add an example that shows how we can override a config from the base config.
|
||
```javascript | ||
module.exports = { | ||
extends: require.resolve('webpack-config-foo'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need better documentation here on how to create and publish webpack-config-foo
. But we can add it later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need better documentation here on how to create and publish
webpack-config-foo
. But we can add it later.
More work needs to be done here. Ideally, consumers of a config should be able to pass options like we do for plugins.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll create a new issue for this on the webpack-cli project
Co-authored-by: Nitin Kumar <snitin315@gmail.com>
Added a section for this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for contributing on this 🚀
describe your changes...
Adds docs for the
extends
option added to webpack-cli in PR webpack/webpack-cli#3738Closes #6801