Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added codemods for migrating webpack from v4 to v5 #7388

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

akash-kumar-dev
Copy link

This PR enhances the webpack v5 from v4 migration guide by incorporating codemod integration to streamline the upgrade process for developers. The motivation behind this change is to provide a more efficient and time-saving approach for migrating from v4 to v5, helping the community upgrade with ease.

Key changes include:

  1. Introducing Codemods: Added a section in the migration guide to highlight the availability of codemods for automating common migration tasks.
  2. Codemod Recipe: Provided a codemod recipe that runs the following codemods from the Sentry.js Codemod repository:
    npx codemod webpack/v5/migration-recipe
    

By incorporating these changes, the migration guide now provides a more comprehensive and efficient solution for upgrading to webpack v5, helping developers save time and effort during the migration process.

Copy link

linux-foundation-easycla bot commented Sep 10, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

Copy link

vercel bot commented Sep 10, 2024

@akash-kumar-dev is attempting to deploy a commit to the Webpack Docs Team on Vercel.

A member of the Team first needs to authorize it.

@chenxsan
Copy link
Member

codemod-com/codemod#1317

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should add note that this is not an official code mod and might fall short in some cases and that the codemod doesn't guarantee 100% of migration, there may be additional manual steps required.

@akash-kumar-dev
Copy link
Author

Thanks for the feedback! I've updated the documentation to clarify that the codemod is unofficial and may require additional manual steps for a complete migration.

@mohab-sameh
Copy link

Hi @snitin315 👋 Mohab from Codemod core team here.

We reviewed and adjusted this from our end as well. Please let me know if there are any changes you'd like to see. Cheers.

@snitin315
Copy link
Member

@mohab-sameh can you sign CLA?

@mohab-sameh
Copy link

@snitin315 Should I sign this personally in addition to the one signed by @alexbit-codemod on behalf of Codemod?

@snitin315
Copy link
Member

You can sign it personally

@mohab-sameh
Copy link

@snitin315 done. Ready to merge now.

Copy link

vercel bot commented Oct 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2024 8:48am

@mohab-sameh
Copy link

@snitin315 Just checking up on this. CLA should be signed. Please let me know if you'd like the core team to make more changes or do final reviews so we can merge this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants