Skip to content

Added Discord icon to Header #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from

Conversation

shellyverma
Copy link
Contributor

@shellyverma shellyverma commented Apr 5, 2025

Added a Discord icon to the Header

  • Read and sign the CLA. PRs that haven't signed it won't be accepted.
  • Make sure your PR complies with the writer's guide.
  • Review the diff carefully as sometimes this can reveal issues.
  • Do not abandon your Pull Request: Stale Pull Requests.

Sorry, something went wrong.

Copy link

vercel bot commented Apr 5, 2025

@shellyverma is attempting to deploy a commit to the OpenJS Foundation Team on Vercel.

A member of the Team first needs to authorize it.

@shellyverma shellyverma closed this Apr 5, 2025
@shellyverma shellyverma reopened this Apr 5, 2025
@shellyverma shellyverma changed the title Added Discord icon to footer Added Discord icon to Header Apr 5, 2025
@shellyverma
Copy link
Contributor Author

Hi @snitin315 @alexander-akait
If there's anything that needs to be changed from my side, please let me know — happy to fix it!
If everything looks good, kindly consider merging the PR
Also, could you please assign me this issue?

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

vercel bot commented Apr 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
webpack-js-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 19, 2025 2:33am

Copy link
Member

@snitin315 snitin315 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shellyverma Thanks for the PR. Currently, after this change header looks too crowded, let's just add discord link in footer.

Copy link

linux-foundation-easycla bot commented Apr 19, 2025

CLA Missing ID CLA Not Signed

@shellyverma shellyverma deleted the add-discord-icon branch April 19, 2025 20:01
@shellyverma shellyverma mentioned this pull request Apr 19, 2025
4 tasks
shelly verma and others added 3 commits April 19, 2025 23:53
@shellyverma shellyverma mentioned this pull request Apr 20, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants