-
-
Notifications
You must be signed in to change notification settings - Fork 8.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Webpack 2 Error with Eslint 2 #2041
Comments
I don't see a conflict here: |
@sokra yeh I was thinking the same but I don't know what else would cause it or where to look for help? Any suggestions? |
I updated the acorn version to ^3.0.0. Maybe this fixes the issue |
@sokra I can confirm this fixes my issue when I installed the latest version from |
Would love a new release! |
Webpack will not work with ESLint 2.0 due to conflicting deps on acorn (webpack/webpack#2041). Downgrade until next release of Webpack
This was because espree was monkey-patching acorn. This was fixed in espree: eslint/js#250 I can confirm that updating to espree 3.0.2 fixes this issue for me. |
Looks like the issue has been fixed based on webpack-contrib/eslint-loader#80. Closing. |
Sorry for duplicate issues but I'm really unsure what repo this issue belongs in. webpack-contrib/eslint-loader#80. Looking at the updated dependencies I'm guessing this is some sort of issue with
acorn
versions but I'm not sure?Webpack 2 has a dependency on
"acorn": "^2.4.0"
, and Eslint 2 has a dependency on"espree": "^3.0.0"
which in turn has a dependency on"acorn": "^2.7.0"
."acorn": "^2.4.0"
"espree": "^3.0.0"
=>"acorn": "^2.7.0"
Eslint 2 has a dependency on
"espree": "^2.2.4"
which in turn has NOacorn
dependency so I'm guessing whatever is happening is some sort of conflict inacorn
but I'm unsure how this plays out."acorn": "^2.4.0"
"espree": "^2.2.4"
I think this could be an NPM 3 semver thing where NPM tries to be smart and and sees two versions of
acorn
with^2.x
and extracts them out into the root ofnode_modules
Upon updating to Eslint 2 and Webpack 2 I get an error in
espree
shown below. With Webpack 1 I don't get this error, and with Webpack2.0.7.-beta
and Eslint1.x
I don't get the error as well. If you have any ideas and cold point me in the right direction I'd appreciate it.The text was updated successfully, but these errors were encountered: