fix: produces correct code when 'output.iife' is false & 'output.library.type' is 'umd', & it gives a warning to the users. #18929
+143
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: produces correct code when 'output.iife' is false & 'output.library.type' is 'umd', & it gives a warning to the users.
|
For maintainers only:
|
lib/RuntimeTemplate.js
Outdated
| return ( | ||
| this.outputOptions.iife || | ||
| (this.outputOptions.library && this.outputOptions.library.type === "umd") | ||
| ); |
There was a problem hiding this comment.
Don't change it, move check to the place where we have isIIFE check
| external: "./non-external" | ||
| } | ||
| }, | ||
| ignoreWarnings: [error => error.name === "FalseIifeUmdWarning"] |
There was a problem hiding this comment.
Can you add a test case where we check that a library works fine?
alexander-akait
approved these changes
Nov 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #18687
What kind of change does this PR introduce?
This PR adds an IIFE wrapper around the returned code when a user sets
output.iife = false&output.library.type = "umd".Did you add tests for your changes?
Yes
Does this PR introduce a breaking change?
No
What needs to be documented once your changes are merged?
A warning note under https://webpack.js.org/configuration/output/#type-umd