Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Can't save auto-filled suggested password #2131

Closed
SuaYoo opened this issue Nov 6, 2024 · 0 comments · Fixed by #2148
Closed

[Bug]: Can't save auto-filled suggested password #2131

SuaYoo opened this issue Nov 6, 2024 · 0 comments · Fixed by #2148
Assignees
Labels
bug Something isn't working front end Requires front end dev work

Comments

@SuaYoo
Copy link
Member

SuaYoo commented Nov 6, 2024

Browsertrix Version

v1.12.0-6032e28

What did you expect to happen? What happened instead?

When changing password in account settings, auto-filling the new password with a suggested password doesn't trigger password strength validation, so the submit button doesn't get enabled.

Reproduction instructions

Pre-req: Browser setup where passwords are auto-suggested

  1. Log in
  2. Go to account icon dropdown -> "Account Settings"
  3. Click "Change Password"
  4. Enter current password
  5. Focus on new password input and accept password suggestion. Observe "Save" button remains disabled

Screenshots / Video

No response

Environment

No response

Additional details

We probably need to check password strength on an additional blur event.

@SuaYoo SuaYoo added bug Something isn't working front end Requires front end dev work labels Nov 6, 2024
@SuaYoo SuaYoo self-assigned this Nov 6, 2024
@ikreymer ikreymer moved this from Triage to Todo in Webrecorder Projects Nov 6, 2024
@SuaYoo SuaYoo moved this from Todo to Ready in Webrecorder Projects Nov 6, 2024
@SuaYoo SuaYoo moved this from Ready to Implementing in Webrecorder Projects Nov 13, 2024
@SuaYoo SuaYoo moved this from Implementing to In Review in Webrecorder Projects Nov 13, 2024
@github-project-automation github-project-automation bot moved this from In Review to Done! in Webrecorder Projects Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front end Requires front end dev work
Projects
Status: Done!
Development

Successfully merging a pull request may close this issue.

1 participant