Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Check password strength on password auto-fill #2148

Merged
merged 4 commits into from
Nov 19, 2024

Conversation

SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Nov 13, 2024

Fixes #2131

Changes

Fixes password strength not being checked when new passwords are auto-filled, resulting in submit buttons remaining disabled.

Manual testing

  1. Sign up for new Browsertrix subscription until account registration page is shown
  2. Auto-fill password. Verify password strength is shown as expected
  3. Save
  4. Go to account settings -> Security
  5. Repeat step 2-3 for changing password
  6. Log out
  7. Request password reset
  8. Repeat step 2-3 for resetting password

@SuaYoo SuaYoo merged commit 333ab6d into main Nov 19, 2024
2 checks passed
@SuaYoo SuaYoo deleted the frontend-fix-account-settings-password branch November 19, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Can't save auto-filled suggested password
2 participants