Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure Subscription Update doesn't update the gifted quotas #2012

Merged
merged 3 commits into from
Aug 20, 2024
Merged

Ensure Subscription Update doesn't update the gifted quotas #2012

merged 3 commits into from
Aug 20, 2024

Conversation

ikreymer
Copy link
Member

  • add a separate OrgQuotasIn where all quota updates are optional
  • ensure gifted quotas are never updated as part of org update
  • update tests

@ikreymer ikreymer requested a review from tw4l August 12, 2024 16:54
@ikreymer ikreymer requested a review from emma-sg August 20, 2024 01:11
emma-sg
emma-sg approved these changes Aug 20, 2024
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I might name OrgQuotasIn something like PartialOrgQuotas, but not a big deal

@ikreymer ikreymer merged commit 8c9a14b into main Aug 20, 2024
4 checks passed
@ikreymer ikreymer deleted the org-quotas-gifted-mins-optional branch August 20, 2024 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emma-sg emma-sg emma-sg approved these changes

@tw4l tw4l Awaiting requested review from tw4l

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ikreymer @emma-sg