chore: Improve time to load org UI #2044
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuaYoo
force-pushed
the
frontend-improve-org-load-time
branch
from
8803af8
to
69a9805
Compare
Shrinks99
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Tested, seems to work!
Eslint has one warning, still haven't figured out why I get these when other people don't... Maybe worth checking?
/Users/henry/Documents/GitHub/webrecorder/browsertrix/frontend/src/index.ts
812:50 warning Unsafe argument of type `any` assigned to a parameter of type `APIUser` @typescript-eslint/no-unsafe-argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2015
Changes
Improves time to first load an org with the following:
Manual testing
Log in as superadmin and regular user. App should feel like it loads slightly faster/more responsive.
Follow-ups
We could probably store app settings for longer in local storage. Maybe based on the app version number, or a longer expiry date.