feat: Display scale as number of browser windows #2057
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I think we can use "crawling" here!
@SuaYoo IDK if your version of mkdocs is doing this (I think it was released in a newer version, I'm on 1.6), but it will show you in the terminal if you have broken links! Useful for nailing down stuff like this.
Shrinks99
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Looks good to me! I think this will be a small but helpful bit of de-jargoning! :)
When I was testing earlier, I observed NaN values in the workflow settings tab but I'm pretty sure this was a cache issue. I can't reproduce it and it seems to work as expected.
Only one real thought (see comment on the docs link), but can leave for later.
| href="https://docs.browsertrix.com/user-guide/workflow-setup/#browser-windows" | ||
| class="text-blue-600 hover:text-blue-500" | ||
| target="_blank" | ||
| >${msg("See caveats")}</a |
There was a problem hiding this comment.
Don't have to do it for this PR, but it would be really cool if docs links we link to in the app opened up in the sidebar!
SuaYoo
commented
Aug 30, 2024
tw4l
approved these changes
Sep 5, 2024
ikreymer
approved these changes
Sep 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2048
Changes
numBrowsersfrom API app settingsManual testing
Screenshots
Follow-ups
There's a bug where the "Edit Browser Settings" button isn't enabled until the crawl is
running, even though the value can be updated during any active crawl state. Should be addressed with #2059