-
-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ensure collection replay is fully reload (cache cleared) when: #2176
ensure collection replay is fully reload (cache cleared) when: #2176
Conversation
ikreymer
commented
Nov 23, 2024
•
edited
Loading
edited
- editing collection metadata
- adding / remove collection items
- storages: don't default to 'use_access_for_presign' to true, fixes support for custom CDN on DO
- fixes missing string 'Removing X items from collection', was not wrapped in msg()
- fixes [Bug]: Collection replay should be fully updated when an item is added or removed #2175
14496d5
to
ba3cac0
Compare
- editing collection metadata - adding / remove collection items
…tting (defaulting to false)
ba3cac0
to
6cf62ce
Compare
Testing locally in Brave, most of the time when I add or remove an archived item in a collection while on the Replay tab there's a console error "tab-list.ts:296 Full reload not available in RWP" and I still have to manually purge the cash/reload in the UI. Weirdly 1 or 2 out of every 10 attempts seems to work? |
Hm, that is odd, yes, if the message is printed, then its not reloading :( |
I can't seem to get the reload to trigger reliably after modifying the items in the collection. Tested with Firefox and Chrome. I did have it work at least once on dev with Chrome, this screencast is from running it locally with Firefox. Screen.Recording.2024-11-22.at.11.07.13.PM.mov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for testing confusion! Tested again on dev, works great.
89d8cc9
to
61662b4
Compare
Merge 1.12.2 release changes into main, includes: - Collection replay full refresh on metadata / archived items (#2176) - Fix for self-registration default org (#2178) - Prepend missing https in start URL (#2177) - Updated billing to support free trial messaging (#2179) --------- Co-authored-by: sua yoo <sua@webrecorder.org> Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics> Co-authored-by: sua yoo <sua@suayoo.com> Co-authored-by: SuaYoo <SuaYoo@users.noreply.github.com>
Merge 1.12.2 release changes into main, includes: - Collection replay full refresh on metadata / archived items (#2176) - Fix for self-registration default org (#2178) - Prepend missing https in start URL (#2177) - Updated billing to support free trial messaging (#2179) --------- Co-authored-by: sua yoo <sua@webrecorder.org> Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics> Co-authored-by: sua yoo <sua@suayoo.com> Co-authored-by: SuaYoo <SuaYoo@users.noreply.github.com>