Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ensure collection replay is fully reload (cache cleared) when: #2176

Merged
merged 5 commits into from
Nov 23, 2024

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 23, 2024

@ikreymer ikreymer force-pushed the replay-full-reload-on-collection-edit branch from 14496d5 to ba3cac0 Compare November 23, 2024 03:44
- editing collection metadata
- adding / remove collection items
@ikreymer ikreymer force-pushed the replay-full-reload-on-collection-edit branch from ba3cac0 to 6cf62ce Compare November 23, 2024 03:45
@tw4l
Copy link
Member

tw4l commented Nov 23, 2024

Testing locally in Brave, most of the time when I add or remove an archived item in a collection while on the Replay tab there's a console error "tab-list.ts:296 Full reload not available in RWP" and I still have to manually purge the cash/reload in the UI. Weirdly 1 or 2 out of every 10 attempts seems to work?

@ikreymer
Copy link
Member Author

Testing locally in Brave, most of the time when I add or remove an archived item in a collection while on the Replay tab there's a console error "tab-list.ts:296 Full reload not available in RWP" and I still have to manually purge the cash/reload in the UI. Weirdly 1 or 2 out of every 10 attempts seems to work?

Hm, that is odd, yes, if the message is printed, then its not reloading :(

@Shrinks99
Copy link
Member

I can't seem to get the reload to trigger reliably after modifying the items in the collection. Tested with Firefox and Chrome. I did have it work at least once on dev with Chrome, this screencast is from running it locally with Firefox.

Screen.Recording.2024-11-22.at.11.07.13.PM.mov

Copy link
Member

@Shrinks99 Shrinks99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for testing confusion! Tested again on dev, works great.

@ikreymer ikreymer force-pushed the replay-full-reload-on-collection-edit branch from 89d8cc9 to 61662b4 Compare November 23, 2024 06:50
@ikreymer ikreymer merged commit 070a833 into 1.12.2-release Nov 23, 2024
4 of 5 checks passed
@ikreymer ikreymer deleted the replay-full-reload-on-collection-edit branch November 23, 2024 07:15
@ikreymer ikreymer mentioned this pull request Nov 25, 2024
ikreymer added a commit that referenced this pull request Nov 26, 2024
Merge 1.12.2 release changes into main, includes:
- Collection replay full refresh on metadata / archived items (#2176)
- Fix for self-registration default org (#2178)
- Prepend missing https in start URL (#2177)
- Updated billing to support free trial messaging (#2179)

---------

Co-authored-by: sua yoo <sua@webrecorder.org>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
Co-authored-by: sua yoo <sua@suayoo.com>
Co-authored-by: SuaYoo <SuaYoo@users.noreply.github.com>
tw4l pushed a commit that referenced this pull request Nov 27, 2024
Merge 1.12.2 release changes into main, includes:
- Collection replay full refresh on metadata / archived items (#2176)
- Fix for self-registration default org (#2178)
- Prepend missing https in start URL (#2177)
- Updated billing to support free trial messaging (#2179)

---------

Co-authored-by: sua yoo <sua@webrecorder.org>
Co-authored-by: Henry Wilkinson <henry@wilkinson.graphics>
Co-authored-by: sua yoo <sua@suayoo.com>
Co-authored-by: SuaYoo <SuaYoo@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants