Added includeClassAnno as a workaround for cert-manager v1.14.5 #2268
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ikreymer
reviewed
Dec 31, 2024
| # This is related to the issues webrecorder/browsertrix#1570 and cert-manager/cert-manager#6184 | ||
| # This relates to the new `http01.ingress.ingressClassName` solver spec attribute which got introduced in the recent v1.15 cert-manager version. | ||
| # Cert-manager v1.15 does not want the fields ingressClassName and class be set at the same time. | ||
| includeClassAnno: false |
There was a problem hiding this comment.
I wonder if this should be called something else, like useOldClassField instead of includeClassAnno since its not an annotation and its specifically about the old field?
There was a problem hiding this comment.
So. Should I change it to useOldClassField or what should be a better name for it?
There was a problem hiding this comment.
Yes, let's change it to that if you don't mind and then can merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2267 and #1570