Skip to content

devex: Document workflow table components #2558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
SuaYoo merged 14 commits into from
Apr 24, 2025
Merged

devex: Document workflow table components #2558

SuaYoo merged 14 commits into from
Apr 24, 2025

Conversation

@SuaYoo
Copy link
Member

@SuaYoo SuaYoo commented Apr 22, 2025 •
edited
Loading

WIP for #2497

Changes

  • Documents the following components in Storybook:
    • btrix-data-table
    • btrix-table
    • btrix-crawl-log-table
    • btrix-custom-behaviors-table
    • btrix-link-selector-table
    • btrix-queue-exclusion-table
    • btrix-queue-exclusion-form
  • Refactors btrix-table and subcomponents to simplify CSS properties
  • Fixes crawl exclusion table delete button not rendering
  • Fixes Shoelace assets not loading Storybook

Manual testing

  1. Run yarn storybook:watch
  2. Click each table component. Verify component states render as expected

Screenshots

Page Image/video
Storybook Screenshot 2025-04-21 at 8 41 20 PM

@SuaYoo SuaYoo mentioned this pull request Apr 22, 2025
Open
3 tasks
@SuaYoo SuaYoo marked this pull request as ready for review April 22, 2025 03:42
@SuaYoo SuaYoo requested review from emma-sg and ikreymer April 22, 2025 03:43
emma-sg
emma-sg approved these changes Apr 23, 2025
View reviewed changes
Copy link
Member

@emma-sg emma-sg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@SuaYoo SuaYoo merged commit 573d8ca into main Apr 24, 2025
27 checks passed
@SuaYoo SuaYoo deleted the frontend-refactor-table-padding branch April 24, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@emma-sg emma-sg emma-sg approved these changes

@ikreymer ikreymer Awaiting requested review from ikreymer

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuaYoo @emma-sg