Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Poorer replay quality than IA wayback (same resources!) #527

Closed
danielbicho opened this issue Dec 13, 2019 · 10 comments
Closed

Poorer replay quality than IA wayback (same resources!) #527

danielbicho opened this issue Dec 13, 2019 · 10 comments

Comments

@danielbicho
Copy link
Contributor

Expected behavior

While replaying this page https://arquivo.pt/wayback/20080106005803/http://www.ojogo.pt/ we get poorer replay quality than https://web.archive.org/web/20080106005803/http://www.ojogo.pt/ even though is the same collection.

Maybe worth to checkout the difference from pywb and whatever wayback IA is using.

pywb image using memento endpoint to IA:
image

IA wayback with the same page:
image
@dubiouscript
Copy link

dubiouscript commented Jan 4, 2020 •
edited
Loading

which pywb ?

git or pkg-mgr install ??

@dubiouscript dubiouscript mentioned this issue Jan 5, 2020
Closed
@danielbicho
Copy link
Contributor Author

pywb versions 2+, didn't try with the oldest versions

@danielbicho danielbicho mentioned this issue Jan 10, 2020
Closed
@edsu
Copy link
Contributor

edsu commented Jan 10, 2020 •
edited
Loading

I don't know if it's related, but I noticed that the aquivo.pt version throws a JavaScript error:

ReferenceError: addthis_share is not defined

whereas the archive.org does not. Could that be interfering somehow?

@danielbicho
Copy link
Contributor Author

danielbicho commented Jan 10, 2020 •
edited
Loading

Thx for pointing out!!

Doesn't seem related is just a error in our interface.
No frame version https://arquivo.pt/noFrame/replay/20080106005803/http://www.ojogo.pt/

Also the test above was performed using only pywb with Internet Archive Memento endpoint! No Arquivo.pt infrastructure/resources or customization

@edsu
Copy link
Contributor

edsu commented Jan 10, 2020

Just fyi, that throws another JavaScript error:

ReferenceError: WRP_SECTION is not defined

Could JavaScript errors be preventing wombat from running correctly?

ikreymer added a commit to webrecorder/wombat that referenced this issue Jan 11, 2020
@ikreymer
rewriteHTML/write fix: add toLowerCase() to rewritten html when check…
e261c19 
…ing if end tag was already present,

otherwise end tag may be inadvertantly removed if original html was not lower case!
should fix rewriting issue in webrecorder/pywb#527
@ikreymer
Copy link
Member

This was a tricky one! Turns out this error (and others) are not related, but had to do with the document.write override in wombat. Should have a fix shortly.

ikreymer added a commit to webrecorder/wombat that referenced this issue Jan 11, 2020
@ikreymer
Fix case in rewrite html end-tag check (#21)
b8a7535 
* rewriteHTML/write fix: add toLowerCase() to rewritten html when checking if end tag was already present,
otherwise end tag may be inadvertantly removed if original html was not lower case!
should fix rewriting issue in webrecorder/pywb#527

* tweak test, fix service-worker-allowed header
ikreymer added a commit that referenced this issue Jan 11, 2020
@ikreymer
rewrite fixes:
149acae 
- dash rewrite fix for fb: when rewriting, match quoted '"dash_prefetched_representation_ids"' as well as w/o quotes,
update tests to ensure rewriting both old and new formats
- wombat update to fix #527: ensure document.write() doesn't accidentally remove end-tag if end-tag was not lowercase (see webrecorder/wombat#21)
@ikreymer ikreymer mentioned this issue Jan 11, 2020
Merged
8 tasks
@ikreymer
Copy link
Member

@danielbicho the fix has been merged into develop. Please re-open if the issue persists with the latest, otherwise should be in the next full release!

@danielbicho
Copy link
Contributor Author

Thank you @ikreymer. perfect!
Tested the f0b9d5b commit, the last commit (93ce4f6) is breaking pywb

@ikreymer
Copy link
Member

@danielbicho what is the issue are you having with the latest commit? Do you want to open a new issue?

@danielbicho
Copy link
Contributor Author

@ikreymer something breaks with our pywb framed version (custom template). I didn't have time to properly evaluate the issue. Will open a new issue if needed.

@ikreymer ikreymer mentioned this issue Jan 18, 2020
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@edsu @ikreymer @danielbicho @dubiouscript