proxy mode: replay improvements for content not captured via proxy mode #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- if preflight OPTIONS request, respond directly (don't attempt OPTIONS capture lookup) - if preflight CORS request, ensure response has appropriate CORS headers, even if not captured - wombat: update to latest wombat with updated Date() fixed timezone in proxy mode
m4rk3r
approved these changes
Nov 12, 2019
Codecov Report
@@ Coverage Diff @@
## develop #520 +/- ##
===========================================
- Coverage 88.09% 87.93% -0.16%
===========================================
Files 64 64
Lines 7922 7934 +12
Branches 1420 1425 +5
===========================================
- Hits 6979 6977 -2
- Misses 607 615 +8
- Partials 336 342 +6
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Better replay of content captured in rewriting/native mode, but replayed in proxy mode (eg. WR desktop/player)
Ensure preflight OPTIONS request is handled correctly and CORS headers added.
Motivation and Context
When capturing in native/rewriting mode, CORS headers and OPTIONS are not sent and never captured. However, when replaying in proxy mode, browser expects CORS headers to be there.
This ensures that CORS headers are added in proxy mode.
Screenshots (if appropriate):
Types of changes
Checklist: