Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure limit applies to XmlQuery index #523

Merged
merged 1 commit into from
Nov 22, 2019
Merged

Ensure limit applies to XmlQuery index #523

merged 1 commit into from
Nov 22, 2019

Conversation

ikreymer
Copy link
Member

@ikreymer ikreymer commented Nov 22, 2019 •
edited
Loading

Description

Ensures the XML query based lookup index also includes a limit, if any.

Motivation and Context

Should address issue in ukwa/ukwa-pywb#49

Screenshots (if appropriate):

Types of changes

  • Replay fix (fixes a replay specific issue)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added or updated tests to cover my changes.
  • All new and existing tests passed.

@ikreymer ikreymer merged commit 0be8452 into develop Nov 22, 2019
@ikreymer ikreymer deleted the xmlquery-limit branch January 18, 2020 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ikreymer